Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable arm32v6 and arm32v7 builds #447

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Sep 28, 2023

Builds for these architectures were broken for some time, but this should be resolved now, so we can re-enable these (fingers crossed).

This reverts commit 461a3ec.

Builds for these architectures were broken for some time, but this
should be resolved now, so we can re-enable these (fingers crossed).

This reverts commit 461a3ec.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Contributor Author

@tianon @yosifkit PTAL (not exactly sure how to verify this locally, so just push the PR)

@thaJeztah
Copy link
Contributor Author

CI looks happy, and I see some armhf / armv6 strings in the logs (but not sure if it actually did those builds and tested them; it's possible other changes are needed to re-enable 🙈)

Copy link
Member

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built arm32v6 and arm32v7 locally with qemu-user-static and also built arm32v7 on an arm64v8 aws server.

@thaJeztah
Copy link
Contributor Author

Thanks for checking!

@tianon
Copy link
Member

tianon commented Sep 28, 2023

I tested on an arm32v7 box and they seem OK; my v6 box is less accessible, so it seems pretty reasonable IMO to roll the dice and assume it's fixed. 😄

@yosifkit yosifkit merged commit 52a2206 into docker-library:master Sep 29, 2023
8 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Sep 29, 2023
Changes:

- docker-library/docker@52a2206: Merge pull request docker-library/docker#447 from thaJeztah/reenable_arm32
- docker-library/docker@b0550bb: re-enable arm32v6 and arm32v7 builds
@thaJeztah thaJeztah deleted the reenable_arm32 branch September 29, 2023 06:46
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Oct 2, 2023
Changes:

- docker-library/docker@c0e8bf9: Merge pull request docker-library/docker#448 from infosiftr/remove-23
- docker-library/docker@ff78b7b: Remove version 23.x
- docker-library/docker@52a2206: Merge pull request docker-library/docker#447 from thaJeztah/reenable_arm32
- docker-library/docker@b0550bb: re-enable arm32v6 and arm32v7 builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing os/arch if using specific version tag Docker 19.03.13 for arm32v7 build failing
3 participants